AndrewJSchofield commented on code in PR #15909:
URL: https://github.com/apache/kafka/pull/15909#discussion_r1597080823
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##########
@@ -255,11 +257,15 @@ public long maximumTimeToWait(long currentTimeMs) {
* member to {@link MemberState#JOINING}, so that it rejoins the group.
*/
public void resetPollTimer(final long pollMs) {
+ pollTimer.update(pollMs);
if (pollTimer.isExpired()) {
Review Comment:
Yes, makes sense. When I was reviewing the previous iteration, I found
myself looking within the Timer at the internal variables and then trying to
figure out whether the derivation being performed was valid. Makes sense to do
it within the Timer. Perfectly happy with 2 methods like this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
