jolshan commented on code in PR #15964:
URL: https://github.com/apache/kafka/pull/15964#discussion_r1602400486
##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntimeTest.java:
##########
@@ -1072,8 +1174,8 @@ public void replay(
@Test
public void testScheduleWriteOpWhenWriteFails() {
MockTimer timer = new MockTimer();
- // The partition writer only accept on write.
- MockPartitionWriter writer = new MockPartitionWriter(2);
+ // The partition writer only accept one write.
Review Comment:
for my understanding, we always batched the (in this case 2) records that
were part of the same write operation. For now we aren't changing this, but
moving the logic to the coordinator runtime to make space for the batching
logic as a followup?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
