dajac commented on code in PR #15964:
URL: https://github.com/apache/kafka/pull/15964#discussion_r1604414478
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java:
##########
@@ -1046,12 +1118,18 @@ public void run() {
result
);
- long offset =
partitionWriter.appendEndTransactionMarker(
+ long offset = partitionWriter.append(
tp,
- producerId,
- producerEpoch,
- coordinatorEpoch,
- result
+ VerificationGuard.SENTINEL,
+ MemoryRecords.withEndTransactionMarker(
+ time.milliseconds(),
Review Comment:
`withEndTransactionMarker` takes the current time if we don't specify it.
The reason why I set it explicitly here is to ensure that the mock time is used
in tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
