jolshan commented on code in PR #15964:
URL: https://github.com/apache/kafka/pull/15964#discussion_r1603797394
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java:
##########
@@ -723,30 +757,66 @@ public void run() {
// If the records are not empty, first, they are
applied to the state machine,
// second, then are written to the partition/log, and
finally, the response
// is put into the deferred event queue.
+ long prevLastWrittenOffset =
context.coordinator.lastWrittenOffset();
+ LogConfig logConfig = partitionWriter.config(tp);
+ byte magic = logConfig.recordVersion().value;
+ int maxBatchSize = logConfig.maxMessageSize();
+ long currentTimeMs = time.milliseconds();
+ ByteBuffer buffer =
context.bufferSupplier.get(Math.min(16384, maxBatchSize));
Review Comment:
Nice we got rid of the thread local. 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
