edoardocomar commented on PR #15910:
URL: https://github.com/apache/kafka/pull/15910#issuecomment-2125147371
Hi @gharris1727 ... more about warnings. there are two Java21 compiler
warnings that result in a compile failure
```
[2024-05-22T02:09:24.247Z] > Task :connect:mirror:compileJava
[2024-05-22T02:09:24.247Z]
/home/jenkins/jenkins-agent/workspace/Kafka_kafka-pr_PR-15910@2/connect/mirror/src/main/java/org/apache/kafka/connect/mirror/OffsetSyncStore.java:78:
warning: [this-escape] possible 'this' escape before subclass is fully
initialized
[2024-05-22T02:09:24.247Z] store = createBackingStore(config,
consumer, admin);
[2024-05-22T02:09:24.247Z] ^
[2024-05-22T02:09:24.247Z]
/home/jenkins/jenkins-agent/workspace/Kafka_kafka-pr_PR-15910@2/connect/mirror/src/main/java/org/apache/kafka/connect/mirror/OffsetSyncStore.java:94:
warning: [this-escape] previous possible 'this' escape happens here via
invocation
[2024-05-22T02:09:24.247Z] (error, record) ->
this.handleRecord(record),
[2024-05-22T02:09:24.247Z] ^
[2024-05-22T02:09:24.247Z] error: warnings found and -Werror specified
[2024-05-22T02:09:24.247Z] 1 error
[2024-05-22T02:09:24.247Z] 2 warnings
[2024-05-22T02:09:24.247Z]
[2024-05-22T02:09:24.247Z] > Task :connect:mirror:compileJava FAILED
```
Do you agree that as we introduced overridable methods in the constructor
for test usage, this time we should suppress these with the annotation
@SuppressWarnings("this-escape")
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
