gharris1727 commented on code in PR #15910:
URL: https://github.com/apache/kafka/pull/15910#discussion_r1608965614
##########
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/OffsetSyncStoreTest.java:
##########
@@ -82,77 +86,131 @@ public void testOffsetTranslation() {
@Test
public void testNoTranslationIfStoreNotStarted() {
- try (FakeOffsetSyncStore store = new FakeOffsetSyncStore()) {
- // no offsets exist and store is not started
- assertEquals(OptionalLong.empty(), store.translateDownstream(null,
tp, 0));
- assertEquals(OptionalLong.empty(), store.translateDownstream(null,
tp, 100));
- assertEquals(OptionalLong.empty(), store.translateDownstream(null,
tp, 200));
+ FakeOffsetSyncStore store = new FakeOffsetSyncStore() {
Review Comment:
> if you approve I'd also backport the fix to 3.7
I'm on the fence about that, leaning towards yes. I regret backporting
KAFKA-12468 so far and introducing this issue, and I didn't communicate it
properly to users. I think you can backport this once you have a full release
note written that can be backported at the same time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
