edoardocomar commented on code in PR #15910:
URL: https://github.com/apache/kafka/pull/15910#discussion_r1608896699
##########
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/OffsetSyncStoreTest.java:
##########
@@ -82,77 +86,131 @@ public void testOffsetTranslation() {
@Test
public void testNoTranslationIfStoreNotStarted() {
- try (FakeOffsetSyncStore store = new FakeOffsetSyncStore()) {
- // no offsets exist and store is not started
- assertEquals(OptionalLong.empty(), store.translateDownstream(null,
tp, 0));
- assertEquals(OptionalLong.empty(), store.translateDownstream(null,
tp, 100));
- assertEquals(OptionalLong.empty(), store.translateDownstream(null,
tp, 200));
+ FakeOffsetSyncStore store = new FakeOffsetSyncStore() {
Review Comment:
Hi @gharris1727 I use IntelliJ too and see the warning. I am reluctant to
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
