lianetm commented on code in PR #16017:
URL: https://github.com/apache/kafka/pull/16017#discussion_r1617867711
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java:
##########
@@ -880,4 +880,25 @@ private HeartbeatRequestManager
createHeartbeatRequestManager(
backgroundEventHandler,
metrics);
}
+
+
+ @Test
+ public void reproduceHeartbeatFail() throws InterruptedException {
Review Comment:
I'm afraid in some time from now we won't know what heartbeat failure this
test refers to (without reading the whole test). So what about renaming this to
something like `testLeaveGroupSentOnCloseWhenPreviousOneInflight` or something
along those lines
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
