lianetm commented on code in PR #16017:
URL: https://github.com/apache/kafka/pull/16017#discussion_r1617881113
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java:
##########
@@ -880,4 +880,25 @@ private HeartbeatRequestManager
createHeartbeatRequestManager(
backgroundEventHandler,
metrics);
}
+
+
+ @Test
+ public void reproduceHeartbeatFail() throws InterruptedException {
+ mockStableMember();
+ time.sleep(DEFAULT_HEARTBEAT_INTERVAL_MS);
+ NetworkClientDelegate.PollResult result =
heartbeatRequestManager.poll(time.milliseconds());
+ assertEquals(1, result.unsentRequests.size());
+
+ result = heartbeatRequestManager.poll(time.milliseconds());
+ assertEquals(0, result.unsentRequests.size(), "No heartbeat should be
sent while a previous one is in-flight");
+
+ membershipManager.transitionToSendingLeaveGroup(true);
+ assertTrue(membershipManager.isLeavingGroup());
+
+ NetworkClientDelegate.PollResult resultAfterLeaving =
heartbeatRequestManager.poll(time.milliseconds());
+ assertEquals(1, resultAfterLeaving.unsentRequests.size());
+ NetworkClientDelegate.PollResult pollAgain =
heartbeatRequestManager.poll(time.milliseconds());
+ assertEquals(0, pollAgain.unsentRequests.size());
+ assertEquals(ConsumerGroupHeartbeatRequest.LEAVE_GROUP_MEMBER_EPOCH,
membershipManager.memberEpoch());
Review Comment:
I would remove this line if we agree on my comment above. We don't need to
care about what this other component does, as long as the one we're unit
testing ends up generating the request we are looking for.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
