frankvicky commented on code in PR #16017:
URL: https://github.com/apache/kafka/pull/16017#discussion_r1619740146
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java:
##########
@@ -752,6 +752,26 @@ public void
testFencedMemberStopHeartbeatUntilItReleasesAssignmentToRejoin() {
assertEquals(1, result.unsentRequests.size(), "Fenced member should
resume heartbeat after transitioning to JOINING");
}
+ @ParameterizedTest
+ @ApiKeyVersionsSource(apiKey = ApiKeys.CONSUMER_GROUP_HEARTBEAT)
+ public void testSendingLeaveGroupHeartbeatWhenPreviousOneInFlight(final
short version) {
+ mockStableMember();
+ time.sleep(DEFAULT_HEARTBEAT_INTERVAL_MS);
+ NetworkClientDelegate.PollResult result =
heartbeatRequestManager.poll(time.milliseconds());
+ assertEquals(1, result.unsentRequests.size());
+ result = heartbeatRequestManager.poll(time.milliseconds());
+ assertEquals(0, result.unsentRequests.size(), "No heartbeat should be
sent while a previous one is in-flight");
+
+ membershipManager.leaveGroup();
+ assertTrue(membershipManager.isLeavingGroup());
Review Comment:
This makes sense. In the unit test for 'HeartBratRequestManager,' we should
focus solely on its functionality.
I will remove this line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
