soarez commented on code in PR #14628:
URL: https://github.com/apache/kafka/pull/14628#discussion_r1673749083
##########
core/src/main/scala/kafka/tools/StorageTool.scala:
##########
@@ -60,7 +63,11 @@ object StorageTool extends Logging {
if (!metadataVersion.isKRaftSupported) {
throw new TerseFailure(s"Must specify a valid KRaft metadata
version of at least 3.0.")
}
- val metaProperties = buildMetadataProperties(clusterId, config.get)
Review Comment:
I'm keen for @cmccabe to confirm, but suspect this is not intentional.
Since we released 3.7, 3.7.1 and soon 3.8 without this validation, we should
continue to accept it in the broker startup logic so we don't break anyone's
existing cluster. But I don't see a reason why we shouldn't add the validation
back to StorageTool, to prevent new clusters being created with a non UUID
value for cluster ID. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
