soarez commented on code in PR #14628:
URL: https://github.com/apache/kafka/pull/14628#discussion_r1677606259
##########
core/src/main/scala/kafka/tools/StorageTool.scala:
##########
@@ -60,7 +63,11 @@ object StorageTool extends Logging {
if (!metadataVersion.isKRaftSupported) {
throw new TerseFailure(s"Must specify a valid KRaft metadata
version of at least 3.0.")
}
- val metaProperties = buildMetadataProperties(clusterId, config.get)
Review Comment:
> If this was an accident, I don't think we should make it permanent.
@ijuma could you clarify your suggestion a bit? Do you mean that we
shouldn't make it permanent:
1. only in the generation of meta.properties (StorageTool)
2. also in the loading of meta.properties (KafkaRaftServer)
3. (some other option?)
If you're suggesting we re-introduce loading validation (2), are there any
options for operators that have created clusters in production with cluster IDs
that would fail that validation? Or should we not mind those?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
