chia7712 commented on code in PR #14628:
URL: https://github.com/apache/kafka/pull/14628#discussion_r1674672583
##########
core/src/main/scala/kafka/tools/StorageTool.scala:
##########
@@ -60,7 +63,11 @@ object StorageTool extends Logging {
if (!metadataVersion.isKRaftSupported) {
throw new TerseFailure(s"Must specify a valid KRaft metadata
version of at least 3.0.")
}
- val metaProperties = buildMetadataProperties(clusterId, config.get)
Review Comment:
> I don't think we should make it permanent.
If the "uuid check" is added back to `StorageTool`, we have to face
following issues:
1. compatibility (as @soarez mentioned)
2. the conflicts caused by base64. That happens recently in our cluster.
the input cluster id is "lYEJ7pnYNO2ovNYiNRJBGl", but the cluster id stored in
`meta.properties` is "lYEJ7pnYNO2ovNYiNRJBGg".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
