showuon commented on PR #16653: URL: https://github.com/apache/kafka/pull/16653#issuecomment-2247928060
I found an issue while testing this. When we disable the "remote.storage.enable" with "retain" policy, it's good we now can read data from the remote storage. But after the server restarted, the log start will be reset to the log segment baseOffset [here](https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/log/LogLoader.scala#L177-L180) because the remoteStorage is disabled. I can make it counting for "disable policy". But since default value of "disable policy" is "retain", so even if the remote Storage is always disabled, we will still treat all logs as "retained policy". We can't use the local log start/ log start check because we are checking new log start offset here. Thoughts? I'll think about it tomorrow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
