showuon commented on PR #16653:
URL: https://github.com/apache/kafka/pull/16653#issuecomment-2249609777

   @kamalcph , yes, it's quite confusing that `remote.storage.enabled` is 
false, but remote data is fetchable. So, I can see you tried to propose a way 
to distinguish "uploadable + readable" and "readable only" cases, by "null" and 
"retain". It works though, I think it's still confusing users that "null" means 
"uploadable + readable". Besides, it's also confusing that 
`remote.storage.enabled` is true, but "delete" policy set, which we'll delete 
all remote data, and maybe without "upload" and "read" to/from remote storage?
   
   After further thinking, and discussed with my colleagues, I think we should 
introduce one more config, to make all clear. Here's my proposal:
   
![image](https://github.com/user-attachments/assets/b617b221-6515-4445-a588-997e2a454e01)
   
   It makes every case clear, and also, delete remote data should only happen 
when `remote.storage.enable` and `delete` is explicitly set, otherwise, all the 
remote data will still be kept, just no upload/read. 
   
   cc @clolov @satishd , 
   Let me know what you think. If you also agree with it, I'll propose in 
KIP-950 voting thread.
   
    
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to