apoorvmittal10 commented on code in PR #16573:
URL: https://github.com/apache/kafka/pull/16573#discussion_r1696610409
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -1128,6 +1401,26 @@ private void throwIfMemberEpochIsInvalid(
}
}
+ /**
+ * Validates the member epoch provided in the heartbeat request.
+ *
+ * @param member The share group member.
+ * @param receivedMemberEpoch The member epoch.
+ *
+ * @throws FencedMemberEpochException if the provided epoch is ahead or
behind the epoch known
+ * by this coordinator.
+ */
+ private void throwIfShareGroupMemberEpochIsInvalid(
+ ShareGroupMember member,
+ int receivedMemberEpoch
+ ) {
+ if (receivedMemberEpoch > member.memberEpoch()) {
Review Comment:
Yes your understanding is right. The members will be fenced and will require
to re-join with initial epoch. Do you recommend we should change this behaviour?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
