apoorvmittal10 commented on code in PR #16573:
URL: https://github.com/apache/kafka/pull/16573#discussion_r1696647066
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -2080,6 +2715,55 @@ private <T> CoordinatorResult<T, CoordinatorRecord>
consumerGroupFenceMember(
}
}
+ /**
+ * Removes a member from a share group.
+ *
+ * @param group The group.
+ * @param member The member.
+ *
+ * @return A list of records to be applied to the state.
+ */
+ private <T> CoordinatorResult<T, CoordinatorRecord> shareGroupFenceMember(
+ ShareGroup group,
+ ShareGroupMember member,
+ T response
+ ) {
+ List<CoordinatorRecord> records = new ArrayList<>();
+ List<CoordinatorRecord> replayRecords = new ArrayList<>();
+
+ replayRecords.add(newCurrentAssignmentTombstoneRecord(group.groupId(),
member.memberId()));
+ replayRecords.add(newTargetAssignmentTombstoneRecord(group.groupId(),
member.memberId()));
Review Comment:
I can check on this, but I wanted to replay the records as like consumer
group.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
