apoorvmittal10 commented on code in PR #16573:
URL: https://github.com/apache/kafka/pull/16573#discussion_r1696645832
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -1967,6 +2523,60 @@ private Assignment updateTargetAssignment(
}
}
+ /**
+ * Updates the target assignment according to the updated member and
subscription metadata.
+ *
+ * @param group The ShareGroup.
+ * @param groupEpoch The group epoch.
+ * @param updatedMember The updated member.
+ * @param subscriptionMetadata The subscription metadata.
+ * @param subscriptionType The group subscription type.
+ * @param records The list to accumulate any new records.
+ * @return The new target assignment.
+ */
+ private Assignment updateTargetAssignment(
Review Comment:
Though it looks similar but I felt it will be cleaner to have separate
methods as the operations and construction of TargetAssignmentBuilder varies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
