cmccabe commented on code in PR #16760:
URL: https://github.com/apache/kafka/pull/16760#discussion_r1700507652
##########
core/src/main/scala/kafka/cluster/Partition.scala:
##########
@@ -1238,7 +1238,14 @@ class Partition(val topicPartition: TopicPartition,
/**
* Try to complete any pending requests. This should be called without
holding the leaderIsrUpdateLock.
*/
- private def tryCompleteDelayedRequests(): Unit =
delayedOperations.checkAndCompleteAll()
+ def tryCompleteDelayedRequests(): Unit = {
Review Comment:
The issue is that the delayed requests are just semi-related pieces of code
that were waiting for a specific partition transition. It doesn't make sense
for them to block the partition transition (and indeed, they can't, either
before or after this PR -- the transition has already happened on the
controller side.) So throwing an exception here just makes a mess, there are no
upsides as far as I can see. Either in ZK mode or KRaft mode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
