chia7712 commented on PR #16760:
URL: https://github.com/apache/kafka/pull/16760#issuecomment-2263584134

   > We encountered a bug where a delayed request installed by the 
TransactionStateManager threw an exception and caused other metadata updates 
not to be applied. So this does fix a real bug.
   
   I guess `TransactionStateManager` installs the delayed op by 
`replicaManager.appendRecords`? Should we catch the exception for each 
purgatory to make them have chance to complete delayed ops even though there is 
a exception caused by one of delayed op?
   
   ```scala
       CoreUtils.swallow(() => fetch.checkAndComplete(requestKey), "xxx")
       CoreUtils.swallow(() => produce.checkAndComplete(requestKey), "xxx")
       CoreUtils.swallow(() => deleteRecords.checkAndComplete(requestKey), 
"xxx")
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to