jolshan commented on code in PR #16760:
URL: https://github.com/apache/kafka/pull/16760#discussion_r1700558713
##########
core/src/main/scala/kafka/cluster/Partition.scala:
##########
@@ -1238,7 +1238,14 @@ class Partition(val topicPartition: TopicPartition,
/**
* Try to complete any pending requests. This should be called without
holding the leaderIsrUpdateLock.
*/
- private def tryCompleteDelayedRequests(): Unit =
delayedOperations.checkAndCompleteAll()
+ def tryCompleteDelayedRequests(): Unit = {
Review Comment:
Got it -- so we are improving this code path for both. (But I guess ZK is no
more soon anyway 😉 )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]