apoorvmittal10 commented on code in PR #16956:
URL: https://github.com/apache/kafka/pull/16956#discussion_r1736002901
##########
core/src/main/java/kafka/server/share/SharePartition.java:
##########
@@ -881,6 +881,7 @@ private void initialize() {
TopicData<PartitionAllData> state = response.topicsData().get(0);
if (state.topicId() != topicIdPartition.topicId() ||
state.partitions().size() != 1
+ || state.partitions().get(0).errorCode() != Errors.NONE.code()
Review Comment:
I have updated the PR with handling, also made the write persister RPC
async. I have passed the errors from Persister to Share Partition Manager as
there we can take the action of discarding the share partition or re-fetching
the partition epoch. I ll handle that in subsequent PR once leader epoch
handling is merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
