junrao commented on code in PR #16956:
URL: https://github.com/apache/kafka/pull/16956#discussion_r1739394900
##########
core/src/main/java/kafka/server/share/SharePartition.java:
##########
@@ -1599,15 +1655,17 @@ &&
checkForStartOffsetWithinBatch(inFlightBatch.firstOffset(), inFlightBatch.las
}
}
- if (!stateBatches.isEmpty() &&
!isWriteShareGroupStateSuccessful(stateBatches)) {
-
- // Even if write share group state RPC call fails, we will
still go ahead with the state transition.
- log.error("Failed to write the share group state on
acquisition lock timeout for share partition: {}-{} memberId: {}. " +
- "Proceeding with state transition.", groupId,
topicIdPartition, memberId);
+ if (!stateBatches.isEmpty()) {
Review Comment:
While you are at this file, there is an existing typo
`acquistionLockTimerTask`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
