mjsax commented on code in PR #17275:
URL: https://github.com/apache/kafka/pull/17275#discussion_r1776222580
##########
tests/kafkatest/tests/streams/streams_application_upgrade_test.py:
##########
@@ -56,9 +55,9 @@ def perform_broker_upgrade(self, to_version):
node.version = KafkaVersion(to_version)
self.kafka.start_node(node)
- @cluster(num_nodes=6)
- @matrix(from_version=smoke_test_versions, bounce_type=["full"])
- def test_app_upgrade(self, from_version, bounce_type):
+ @cluster(num_nodes=9)
+ @matrix(from_version=smoke_test_versions, bounce_type=["full"],
metadata_quorum=[quorum.combined_kraft])
+ def test_app_upgrade(self, from_version, bounce_type, metadata_quorum):
Review Comment:
If `bounce_type` is always `full`, and `metadata_quorum` is always
`quorum.combined_kraft`, why do we have both as test parameters? Can we not
hard-code both inside the test itself?
Even if I don't even see where `metadata_quorum` is used? Why do we add it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
