mjsax commented on code in PR #17275:
URL: https://github.com/apache/kafka/pull/17275#discussion_r1776227488
##########
tests/kafkatest/tests/streams/streams_broker_bounce_test.py:
##########
@@ -152,16 +151,9 @@ def confirm_topics_on_all_brokers(self,
expected_topic_set):
def setup_system(self, start_processor=True, num_threads=3):
# Setup phase
- self.zk = (
- ZookeeperService(self.test_context, 1)
- if quorum.for_test(self.test_context) == quorum.zk
- else None
- )
- if self.zk:
- self.zk.start()
-
- self.kafka = KafkaService(self.test_context,
num_nodes=self.replication, zk=self.zk, topics=self.topics,
- controller_num_nodes_override=1)
+
+ self.kafka = KafkaService(self.test_context, num_nodes=3, zk=None,
topics=self.topics,
Review Comment:
Would it make sense to change `KafkaService` to use `zk=None` as default so
we don't have to pass it at all any longer? (Of course, touching `KafkaService`
might affect _all_ system tests, so not sure what the impact / splash radius
would be? -- On the other side, if `zk` is mandatory, making it optional with
default `None` might not affect any existing test after all?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
