chia7712 commented on code in PR #17331:
URL: https://github.com/apache/kafka/pull/17331#discussion_r1794728582
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupConfig.java:
##########
@@ -57,13 +62,20 @@ public class GroupConfig extends AbstractConfig {
GroupCoordinatorConfig.CONSUMER_GROUP_HEARTBEAT_INTERVAL_MS_DEFAULT,
atLeast(1),
MEDIUM,
- GroupCoordinatorConfig.CONSUMER_GROUP_HEARTBEAT_INTERVAL_MS_DOC);
+ GroupCoordinatorConfig.CONSUMER_GROUP_HEARTBEAT_INTERVAL_MS_DOC)
+ .define(SHARE_RECORD_LOCK_DURATION_MS_CONFIG,
+ INT,
+ ShareGroupConfig.SHARE_GROUP_RECORD_LOCK_DURATION_MS_DEFAULT,
+ atLeast(1000),
Review Comment:
> The broker config group.share.record.lock.duration.ms is the default
duration when there is no group-specific configuration. This one should be
between(1000, 60000). Most groups will use this config.
My point was why `group.share.record.lock.duration.ms` has a upper bound of
`60000` rather `3600000`? For example, the following configs are illegal.
```
group.share.min.record.lock.duration.ms=30000
group.share.record.lock.duration.ms=65000
group.share.max.record.lock.duration.ms=70000
```
I assumed the rules is
```
group.share.min.record.lock.duration.ms <=
group.share.record.lock.duration.ms <= group.share.max.record.lock.duration.ms
```
However, the actual rule is
```
group.share.min.record.lock.duration.ms <=
group.share.record.lock.duration.ms <= min(60000,
group.share.max.record.lock.duration.ms)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
