apoorvmittal10 commented on code in PR #17331:
URL: https://github.com/apache/kafka/pull/17331#discussion_r1795008371
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupConfig.java:
##########
@@ -57,13 +62,20 @@ public class GroupConfig extends AbstractConfig {
GroupCoordinatorConfig.CONSUMER_GROUP_HEARTBEAT_INTERVAL_MS_DEFAULT,
atLeast(1),
MEDIUM,
- GroupCoordinatorConfig.CONSUMER_GROUP_HEARTBEAT_INTERVAL_MS_DOC);
+ GroupCoordinatorConfig.CONSUMER_GROUP_HEARTBEAT_INTERVAL_MS_DOC)
+ .define(SHARE_RECORD_LOCK_DURATION_MS_CONFIG,
+ INT,
+ ShareGroupConfig.SHARE_GROUP_RECORD_LOCK_DURATION_MS_DEFAULT,
+ atLeast(1000),
Review Comment:
I think the idea is to have a default config
`group.share.min.record.lock.duration.ms` between 1 and 60 secs.
But this can only be changed dynamically using min and max setting, and can
be between 1 sec to 1 hour. But then the lock duration can only be set
dynamically.
Reading it again, I also felt it's a bit confusing and it might be better to
set default config (`group.share.record.lock.duration.ms`) also from 1 sec to
1 hour. Would be good to have @AndrewJSchofield thoughts as he might have
already thought about it and I could be missing something.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
