AndrewJSchofield commented on code in PR #17331:
URL: https://github.com/apache/kafka/pull/17331#discussion_r1797213556
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupConfig.java:
##########
@@ -57,13 +62,20 @@ public class GroupConfig extends AbstractConfig {
GroupCoordinatorConfig.CONSUMER_GROUP_HEARTBEAT_INTERVAL_MS_DEFAULT,
atLeast(1),
MEDIUM,
- GroupCoordinatorConfig.CONSUMER_GROUP_HEARTBEAT_INTERVAL_MS_DOC);
+ GroupCoordinatorConfig.CONSUMER_GROUP_HEARTBEAT_INTERVAL_MS_DOC)
+ .define(SHARE_RECORD_LOCK_DURATION_MS_CONFIG,
+ INT,
+ ShareGroupConfig.SHARE_GROUP_RECORD_LOCK_DURATION_MS_DEFAULT,
+ atLeast(1000),
Review Comment:
Thanks for the comments @chia7712 and @apoorvmittal10. This is working as I
intended, but I can see that people are finding it confusing. I think it
sensible to adjust the maximum for `group.share.record.lock.duration.ms` to
3600000 (1 hour) as suggested. I'll change the KIP and put in a PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
