frankvicky commented on code in PR #17549:
URL: https://github.com/apache/kafka/pull/17549#discussion_r1807323559
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerMembershipManager.java:
##########
@@ -229,16 +227,6 @@ public void
onHeartbeatSuccess(ConsumerGroupHeartbeatResponse response) {
return;
}
- // Update the group member id label in the client telemetry reporter
if the member id has
- // changed. Initially the member id is empty, and it is updated when
the member joins the
- // group. This is done here to avoid updating the label on every
heartbeat response. Also
- // check if the member id is null, as the schema defines it as
nullable.
- if (responseData.memberId() != null &&
!responseData.memberId().equals(memberId)) {
- clientTelemetryReporter.ifPresent(reporter ->
reporter.updateMetricsLabels(
-
Collections.singletonMap(ClientTelemetryProvider.GROUP_MEMBER_ID,
responseData.memberId())));
- }
Review Comment:
see https://github.com/apache/kafka/pull/17549/files#r1807323514
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareMembershipManager.java:
##########
@@ -155,16 +153,6 @@ public void onHeartbeatSuccess(ShareGroupHeartbeatResponse
response) {
return;
}
- // Update the group member id label in the client telemetry reporter
if the member id has
- // changed. Initially the member id is empty, and it is updated when
the member joins the
- // group. This is done here to avoid updating the label on every
heartbeat response. Also
- // check if the member id is null, as the schema defines it as
nullable.
- if (responseData.memberId() != null &&
!responseData.memberId().equals(memberId)) {
- clientTelemetryReporter.ifPresent(reporter ->
reporter.updateMetricsLabels(
-
Collections.singletonMap(ClientTelemetryProvider.GROUP_MEMBER_ID,
responseData.memberId())));
- }
Review Comment:
see https://github.com/apache/kafka/pull/17549/files#r1807323514
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
