frankvicky commented on code in PR #17549:
URL: https://github.com/apache/kafka/pull/17549#discussion_r1807326273
##########
core/src/test/scala/unit/kafka/server/GroupCoordinatorBaseRequestTest.scala:
##########
@@ -569,7 +569,7 @@ class GroupCoordinatorBaseRequestTest(cluster:
ClusterInstance) {
protected def consumerGroupHeartbeat(
groupId: String,
- memberId: String = "",
+ memberId: String = Uuid.randomUuid().toString,
Review Comment:
Since we are upgrading the `ConsumerGroupHeartbeat`, the `memberId` cannot
be empty or null.
It would be nice to test the older version of the protocol, but I'm not
quite sure how to achieve that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
