frankvicky commented on code in PR #17549:
URL: https://github.com/apache/kafka/pull/17549#discussion_r1809998105
##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java:
##########
@@ -10117,8 +10130,9 @@ public void
testConsumerGroupHeartbeatWithPreparingRebalanceClassicGroup() throw
assertEquals(group,
context.groupMetadataManager.getOrMaybeCreateClassicGroup("group-id", false));
}
- @Test
- public void
testConsumerGroupHeartbeatToClassicGroupFromExistingStaticMember() {
+ @ParameterizedTest
+ @ValueSource(booleans = {true, false})
+ public void
testConsumerGroupHeartbeatToClassicGroupFromExistingStaticMember(boolean
isConsumerGeneratedMemberId) {
Review Comment:
Originally, I was thinking covering both scenarios for client-generated
memberId and server-generated memberId. However, based on the previous comment,
I will focus on simulating the behavior of the latest version and update the
test case accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
