mjsax commented on code in PR #17786: URL: https://github.com/apache/kafka/pull/17786#discussion_r1841030801
########## core/src/test/scala/integration/kafka/server/GssapiAuthenticationTest.scala: ########## @@ -109,7 +110,8 @@ class GssapiAuthenticationTest extends IntegrationTestHarness with SaslSetup { * are able to connect after the second re-login. Verifies that logout is performed only once * since duplicate logouts without successful login results in NPE from Java 9 onwards. */ - @Test + @ParameterizedTest + @ValueSource(strings = Array("kraft")) Review Comment: There is no input parameter to `testLoginFailure()` -- why change this to being a parametrized test? (Same below.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org