cmccabe commented on code in PR #17786:
URL: https://github.com/apache/kafka/pull/17786#discussion_r1841217501
##########
core/src/test/scala/integration/kafka/server/GssapiAuthenticationTest.scala:
##########
@@ -92,15 +92,16 @@ class GssapiAuthenticationTest extends
IntegrationTestHarness with SaslSetup {
* Tests that Kerberos replay error `Request is a replay (34)` is not
handled as an authentication exception
* since replay detection used to detect DoS attacks may occasionally reject
valid concurrent requests.
*/
- @Test
- def testRequestIsAReplay(): Unit = {
+ @ParameterizedTest
+ @ValueSource(strings = Array("kraft"))
+ def testRequestIsAReplay(quorum: String): Unit = {
Review Comment:
While the parameter isn't used directly, it affects the test name which some
code in `TestUtils.scala` uses to determine if the test is kraft or not. This
is standard for our kraft tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
