mjsax commented on code in PR #17786:
URL: https://github.com/apache/kafka/pull/17786#discussion_r1841029706
##########
core/src/test/scala/integration/kafka/server/GssapiAuthenticationTest.scala:
##########
@@ -92,15 +92,16 @@ class GssapiAuthenticationTest extends
IntegrationTestHarness with SaslSetup {
* Tests that Kerberos replay error `Request is a replay (34)` is not
handled as an authentication exception
* since replay detection used to detect DoS attacks may occasionally reject
valid concurrent requests.
*/
- @Test
- def testRequestIsAReplay(): Unit = {
+ @ParameterizedTest
+ @ValueSource(strings = Array("kraft"))
+ def testRequestIsAReplay(quorum: String): Unit = {
Review Comment:
Why is `quorum` an input parameter to this test? Seems the value would
always be `"kraft"`? -- I also also don't see where `quorum` is actually used?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
