CalvinConfluent commented on code in PR #17698:
URL: https://github.com/apache/kafka/pull/17698#discussion_r1849318159
##########
core/src/main/scala/kafka/coordinator/transaction/TransactionMetadata.scala:
##########
@@ -490,9 +494,10 @@ private[transaction] class TransactionMetadata(val
transactionalId: String,
}
case CompleteAbort | CompleteCommit => // from write markers
+ // With transaction V2, we allow Empty transaction to be aborted, so
the txnStartTimestamp can be -1.
Review Comment:
The txnStartTimestamp is updated at the beginning of the transaction, not
the end of the transaction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
