jolshan commented on code in PR #17698:
URL: https://github.com/apache/kafka/pull/17698#discussion_r1850687296
##########
core/src/test/scala/integration/kafka/api/TransactionsTest.scala:
##########
@@ -401,6 +401,7 @@ class TransactionsTest extends IntegrationTestHarness {
producer1.beginTransaction()
producer1.send(TestUtils.producerRecordWithExpectedTransactionStatus(topic1,
null, "1", "1", willBeCommitted = false))
producer1.send(TestUtils.producerRecordWithExpectedTransactionStatus(topic2,
null, "3", "3", willBeCommitted = false))
+ producer1.flush()
Review Comment:
Oh this is just happening because we changed the error type. (We don't have
a separate add partitions call that would happen first.) I think we can remove
the flush and just change the error. (commitTransaction should flush anyway)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
