CalvinConfluent commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1849322960
########## core/src/main/scala/kafka/log/UnifiedLog.scala: ########## @@ -629,10 +629,11 @@ class UnifiedLog(@volatile var logStartOffset: Long, /** * Return true if the given producer ID has a transaction ongoing. + * Note, if the incoming producer epoch is newer than the stored one, the transaction may have finished. Review Comment: I think it is possible and we should reject it earlier. We can make a separate PR for this optimization. https://issues.apache.org/jira/browse/KAFKA-18042 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org