lianetm commented on code in PR #17964:
URL: https://github.com/apache/kafka/pull/17964#discussion_r1862442576
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerMetadata.java:
##########
@@ -68,7 +68,7 @@ public boolean allowAutoTopicCreation() {
@Override
public synchronized MetadataRequest.Builder newMetadataRequestBuilder() {
- if (subscription.hasPatternSubscription())
+ if (subscription.hasPatternSubscription() ||
subscription.hasRe2JPatternSubscription())
Review Comment:
uhm makes total sense, I missed that. I will create and take the jira. The
gap is mainly in the subscription state indeed, where we don't keep topic IDs
(that unresolved assignment is kept only in the MembershipMgr). Then we also
need the ConsumerMetadata to build the metadata request based on the topics Ids
if we're using the new pattern (the request builder based on topics IDs already
exists but only used in tests).
-- update
https://issues.apache.org/jira/browse/KAFKA-18117 will follow right after
this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
