chia7712 commented on code in PR #17964:
URL: https://github.com/apache/kafka/pull/17964#discussion_r1863102966


##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerMetadata.java:
##########
@@ -68,7 +68,7 @@ public boolean allowAutoTopicCreation() {
 
     @Override
     public synchronized MetadataRequest.Builder newMetadataRequestBuilder() {
-        if (subscription.hasPatternSubscription())
+        if (subscription.hasPatternSubscription() || 
subscription.hasRe2JPatternSubscription())

Review Comment:
   > I target 4.1 to deprecate them.
   
   Out of curiosity, why aren’t they being deprecated if we aim to set the 
async consumer as the default in version 4.0? Specifically, 
`Consumer#enforceRebalance` is essentially a no-op in `AsyncConsumer`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to