chia7712 commented on code in PR #17964:
URL: https://github.com/apache/kafka/pull/17964#discussion_r1862629152


##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerMetadata.java:
##########
@@ -68,7 +68,7 @@ public boolean allowAutoTopicCreation() {
 
     @Override
     public synchronized MetadataRequest.Builder newMetadataRequestBuilder() {
-        if (subscription.hasPatternSubscription())
+        if (subscription.hasPatternSubscription() || 
subscription.hasRe2JPatternSubscription())

Review Comment:
   > The only exception is the client-side regex but this will be deprecated 
soon.
   
   Is there already a Jira ticket for this? If not, I’d like to create one to 
deprecate the `subscribe(Pattern)` and `enforceRebalance` in accordance with 
KIP-848



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to