smjn commented on code in PR #17957:
URL: https://github.com/apache/kafka/pull/17957#discussion_r1867216438
##########
share/src/main/java/org/apache/kafka/server/share/persister/DefaultStatePersister.java:
##########
@@ -79,7 +79,12 @@ public CompletableFuture<InitializeShareGroupStateResult>
initializeState(Initia
* @return A completable future of WriteShareGroupStateResult
*/
public CompletableFuture<WriteShareGroupStateResult>
writeState(WriteShareGroupStateParameters request) throws
IllegalArgumentException {
Review Comment:
shall we remove checked exception from the method signature?
##########
share/src/main/java/org/apache/kafka/server/share/persister/DefaultStatePersister.java:
##########
@@ -170,7 +175,12 @@ WriteShareGroupStateResult writeResponsesToResult(
* @return A completable future of ReadShareGroupStateResult
*/
public CompletableFuture<ReadShareGroupStateResult>
readState(ReadShareGroupStateParameters request) throws
IllegalArgumentException {
Review Comment:
same here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
