adixitconfluent commented on code in PR #17957:
URL: https://github.com/apache/kafka/pull/17957#discussion_r1867904768
##########
core/src/test/java/kafka/server/share/SharePartitionTest.java:
##########
@@ -771,24 +768,20 @@ public void testMaybeInitializeWithReadException() {
Persister persister = Mockito.mock(Persister.class);
// Complete the future exceptionally for read state.
Mockito.when(persister.readState(Mockito.any())).thenReturn(FutureUtils.failedFuture(new
RuntimeException("Read exception")));
- SharePartition sharePartition =
SharePartitionBuilder.builder().withPersister(persister).build();
+ SharePartition sharePartition1 =
SharePartitionBuilder.builder().withPersister(persister).build();
Review Comment:
I find the code cleaner this way since the 2 instances of `SharePartition`
behave differently, hence the name change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
