chia7712 commented on code in PR #17957:
URL: https://github.com/apache/kafka/pull/17957#discussion_r1868156814
##########
share/src/main/java/org/apache/kafka/server/share/persister/Persister.java:
##########
@@ -40,15 +40,15 @@ public interface Persister {
* @param request Request parameters
* @return A {@link CompletableFuture} that completes with the result.
*/
- CompletableFuture<ReadShareGroupStateResult>
readState(ReadShareGroupStateParameters request) throws
IllegalArgumentException;
+ CompletableFuture<ReadShareGroupStateResult>
readState(ReadShareGroupStateParameters request);
/**
* Write share-partition state.
*
* @param request Request parameters
* @return A {@link CompletableFuture} that completes with the result.
*/
- CompletableFuture<WriteShareGroupStateResult>
writeState(WriteShareGroupStateParameters request) throws
IllegalArgumentException;
Review Comment:
Could you please open a follow-up issue to align exception propagation?
Currently, the methods `deleteState`, `initializeState`, and `readSummary`
still declare exceptions in their method signatures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
