brandboat commented on code in PR #18036:
URL: https://github.com/apache/kafka/pull/18036#discussion_r1874795473
##########
tools/src/main/java/org/apache/kafka/tools/VerifiableConsumer.java:
##########
@@ -649,8 +648,12 @@ public static VerifiableConsumer
createFromArgs(ArgumentParser parser, String[]
if (groupRemoteAssignor != null)
consumerProps.put(ConsumerConfig.GROUP_REMOTE_ASSIGNOR_CONFIG,
groupRemoteAssignor);
} else {
- // This means we're using the old consumer group protocol.
+ // This means we're using the CLASSIC consumer group protocol.
consumerProps.put(ConsumerConfig.PARTITION_ASSIGNMENT_STRATEGY_CONFIG,
res.getString("assignmentStrategy"));
+ Integer sessionTimeout = res.getInt("sessionTimeout");
Review Comment:
> it is fine to throw exception if user does set the --session-timeout
Pardon me, did you mean throw exception if user set session timeout when
using CONSUMER group.protocol ? Not sure if I understand correctly 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
