brandboat commented on code in PR #18036:
URL: https://github.com/apache/kafka/pull/18036#discussion_r1874816095
##########
tests/kafkatest/services/verifiable_consumer.py:
##########
@@ -417,10 +417,13 @@ def start_cmd(self, node):
else:
cmd += " --bootstrap-server %s" %
self.kafka.bootstrap_servers(self.security_config.security_protocol)
- cmd += " --reset-policy %s --group-id %s --topic %s --session-timeout
%s" % \
- (self.reset_policy, self.group_id, self.topic,
- self.session_timeout_sec*1000)
-
+ cmd += " --reset-policy %s --group-id %s --topic %s" % \
+ (self.reset_policy, self.group_id, self.topic)
+
+ # session timeout is not supported when using CONSUMER group protocol
+ if self.session_timeout_sec > 0 and
self.is_consumer_group_protocol_enabled():
Review Comment:
Only `VerifiableConsumerTest` specifically set session timeout, but I think
it's a bit redundant, so I refactor them out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
