chia7712 commented on code in PR #18036:
URL: https://github.com/apache/kafka/pull/18036#discussion_r1874952912
##########
tests/kafkatest/tests/verifiable_consumer_test.py:
##########
@@ -56,7 +55,7 @@ def min_cluster_size(self):
def setup_consumer(self, topic, static_membership=False,
enable_autocommit=False,
assignment_strategy="org.apache.kafka.clients.consumer.RangeAssignor",
group_remote_assignor="range", **kwargs):
return VerifiableConsumer(self.test_context, self.num_consumers,
self.kafka,
- topic, self.group_id,
static_membership=static_membership,
session_timeout_sec=self.session_timeout_sec,
Review Comment:
`session_timeout_sec` is used by other end-to-end tests, so we need to
perform some refactoring for those test cases.
**Replace Dynamic Timeouts with Constants**
For example, change timeout_sec=self.session_timeout_sec + 5 to
timeout_sec=60.
**Remove Use Cases of Increasing session_timeout_sec**
These cases typically increase session_timeout_sec from 45 seconds to 60
seconds. This adjustment may be unnecessary if the tests can run stably without
modifying the timeout.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
