ahuang98 commented on PR #17139: URL: https://github.com/apache/kafka/pull/17139#issuecomment-2549519628
> Apologies for the late reply. I stumbled upon a similar metric in [KafkaRaftMetrics](https://github.com/apache/kafka/blob/9c0fe85605ee675d9e7fcee624ab9f50000c704f/raft/src/main/java/org/apache/kafka/raft/internals/KafkaRaftMetrics.java#L164) which was modified in #13207. Perhaps we should consider a similar logic for parity? One concern I have is unlike the KRaft metric, which is limited to the KRaft Controller, a change in the consumer's metric would have a wider impact. WDYT @hachikuji @jsancio ? Interesting, I had a read of https://github.com/apache/kafka/pull/13207 and I would agree that it would make sense to have parity here (given that this PR has been open for some time already, seems worth it to take the additional time to get the ratio right). Having the poll(0ms) case tested would be great -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
