srdo commented on PR #17139: URL: https://github.com/apache/kafka/pull/17139#issuecomment-2558404730
Regarding https://github.com/apache/kafka/pull/13207, I think that is likely a better solution than the changes made here, since this suffers from exactly the problem described on that PR. Happy to update this to use TimeRatio instead, if people agree that this is the way to go. Only minor comment on that class is that it could be slightly misleading to insert "fake" data points with a `defaultRatio`, rather than more clearly indicating that the value is not valid with e.g. NaN, but it's probably not that important. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
