srdo commented on PR #17139: URL: https://github.com/apache/kafka/pull/17139#issuecomment-2558391902
@ahuang98 I have addressed your comments in the latest commit. Please take another look when you get a chance. As outlined in https://github.com/apache/kafka/pull/17139#discussion_r1890122551, I don't think there is any benefit to choosing to measure the intervals between poll endpoints over poll start points. We will have to exclude a poll from the metric either way, the only difference is whether it's the first or last poll. So I've stuck to measuring intervals from poll start to poll start for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org