ijuma commented on code in PR #18218:
URL: https://github.com/apache/kafka/pull/18218#discussion_r1890441287
##########
core/src/main/scala/kafka/server/KafkaApis.scala:
##########
@@ -834,81 +832,6 @@ class KafkaApis(val requestChannel: RequestChannel,
}
}
- def maybeConvertFetchedData(tp: TopicIdPartition,
- partitionData:
FetchResponseData.PartitionData): FetchResponseData.PartitionData = {
- // We will never return a logConfig when the topic is unresolved and the
name is null. This is ok since we won't have any records to convert.
- val logConfig = replicaManager.getLogConfig(tp.topicPartition)
-
- if (logConfig.exists(_.compressionType == BrokerCompressionType.ZSTD) &&
versionId < 10) {
- trace(s"Fetching messages is disabled for ZStandard compressed
partition $tp. Sending unsupported version response to $clientId.")
- FetchResponse.partitionResponse(tp,
Errors.UNSUPPORTED_COMPRESSION_TYPE)
Review Comment:
I removed this check because it's kind of pointless (this topic config is
rarely used and we never checked for the most common case of compression
happening on the producer) and added unnecessarily complexity once down
conversion was removed. Let me know if this is reasonable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
